[webkit-reviews] review granted: [Bug 64229] Remove array size from generated JSC binding tables : [Attachment 100205] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 10 19:07:48 PDT 2011


Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 64229: Remove array size from generated JSC binding tables
https://bugs.webkit.org/show_bug.cgi?id=64229

Attachment 100205: Patch
https://bugs.webkit.org/attachment.cgi?id=100205&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
Looks like the EWS is happy, so the change seems safe.	I like the idea of
allowing the compiler to compute the size at build time, since it's a horrible
mistake if we declare with one size, but end up generating more (or less)
entries in the table.


More information about the webkit-reviews mailing list