[webkit-reviews] review granted: [Bug 64231] Generate conditional include statements in CodeGeneratorJS : [Attachment 100210] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 64231: Generate conditional include statements in CodeGeneratorJS
https://bugs.webkit.org/show_bug.cgi?id=64231

Attachment 100210: Patch
https://bugs.webkit.org/attachment.cgi?id=100210&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100210&action=review


Great idea!  I have a question (inline), but otherwise looks good.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2948
> +	   foreach my $include (sort keys %implIncludes) {

We didn't sort these keys previously.  Is the sorting just for legibility in
the output? Or is it necessary to get proper function in generating the
conditionalized output?