[webkit-reviews] review granted: [Bug 64244] WebSocket: Add useHixie76Protocol flag to WebSocketChannel and WebSocketHandshake : [Attachment 100236] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 64244: WebSocket: Add useHixie76Protocol flag to WebSocketChannel and
WebSocketHandshake
https://bugs.webkit.org/show_bug.cgi?id=64244

Attachment 100236: Patch
https://bugs.webkit.org/attachment.cgi?id=100236&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100236&action=review


> Source/WebCore/websockets/WebSocketHandshake.cpp:162
> -WebSocketHandshake::WebSocketHandshake(const KURL& url, const String&
protocol, ScriptExecutionContext* context)
> +WebSocketHandshake::WebSocketHandshake(const KURL& url, const String&
protocol, ScriptExecutionContext* context, bool useHixie76Protocol)

We usually avoid a bool argument. But I think it's acceptable in this case
because we have no callers with literal false/true.