[webkit-reviews] review denied: [Bug 13061] Let plugins participate in form submission : [Attachment 100203] Patch V2

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 13061: Let plugins participate in form submission
https://bugs.webkit.org/show_bug.cgi?id=13061

Attachment 100203: Patch V2
https://bugs.webkit.org/attachment.cgi?id=100203&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100203&action=review


Looks great! So close to be able to land!

> Tools/DumpRenderTree/TestNetScapePlugIn/Tests/FormValue.cpp:31
> +class FormValuePlugin : public PluginTest {

Can we just call this "FormValue"? The Plugin adds nothing extra here.
Similarly we'd name the test "form-value"

> Tools/DumpRenderTree/TestNetScapePlugIn/Tests/FormValue.cpp:50
> +    return PluginTest::NPP_GetValue(variable, value);

You should return NPERR_GENERIC_ERROR here instead of the base class.