[webkit-reviews] review granted: [Bug 63797] Add a possibility to retrieve the associated SVGAnimatedProperty object for a certain XML attribute : [Attachment 100180] Patch v7

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 63797: Add a possibility to retrieve the associated SVGAnimatedProperty
object for a certain XML attribute
https://bugs.webkit.org/show_bug.cgi?id=63797

Attachment 100180: Patch v7
https://bugs.webkit.org/attachment.cgi?id=100180&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100180&action=review


Looks great. r=me. Just:

> Source/WebCore/svg/properties/SVGAnimatedPropertyMacros.h:78
> +#define BEGIN_REGISTER_ANIMATED_PROPERTIES(OwnerType) \

think about if you don't want to rename it like I mentioned in a previous
comment.