[webkit-reviews] review granted: [Bug 64138] Clean up RenderWidget::destroy() to share more code : [Attachment 100185] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 64138: Clean up RenderWidget::destroy() to share more code
https://bugs.webkit.org/show_bug.cgi?id=64138

Attachment 100185: Patch
https://bugs.webkit.org/attachment.cgi?id=100185&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100185&action=review


Looks great, just one question.

> Source/WebCore/rendering/RenderWidget.cpp:-142
> -    if (hasOverrideSize())
> -	   setOverrideSize(-1);

this is different from what RenderBox::destroy() did, it did:
gOverrideSizeMap->remove(this)

are these equivalent?