[webkit-reviews] review granted: [Bug 64134] Move innerTextElement() from RenderTextControl to HTMLTextFormControlHTMLTextFormControlElement : [Attachment 100167] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 8 16:44:11 PDT 2011
Kent Tamura <tkent at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 64134: Move innerTextElement() from RenderTextControl to
HTMLTextFormControlHTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64134
Attachment 100167: Patch
https://bugs.webkit.org/attachment.cgi?id=100167&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100167&action=review
> Source/WebCore/rendering/RenderTextControl.h:56
> + HTMLElement* innerTextElement() const;
Let's add a comment that this function should not be public.
Otherwise, one who doesn't know the intention of this patch might make it
public and revert the AccessibilityRenderObject.cpp change.
More information about the webkit-reviews
mailing list