[webkit-reviews] review requested: [Bug 64177] ApplicationCache update should not immediately fail when reaching per-origin quota : [Attachment 100181] [PATCH] Address Comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 8 16:12:19 PDT 2011


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 64177: ApplicationCache update should not immediately fail when reaching
per-origin quota
https://bugs.webkit.org/show_bug.cgi?id=64177

Attachment 100181: [PATCH] Address Comments
https://bugs.webkit.org/attachment.cgi?id=100181&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
• Attempted to address Qt build issues.
• Addressed ap's Review comments:
  - fix the spaceNeeded parameter to account for other caches/manifests in the
domain
    Added a test for this as well, which required changes the delegate dump'd
output.
• Implemented spaceNeeded for Qt to attempt to keep their tests from failing.


More information about the webkit-reviews mailing list