[webkit-reviews] review granted: [Bug 64203] Lists of flaky revisions on TestFailures page can get so long they're hard to navigate : [Attachment 100163] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 8 15:44:24 PDT 2011


Daniel Bates <dbates at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 64203: Lists of flaky revisions on TestFailures page can get so long
they're hard to navigate
https://bugs.webkit.org/show_bug.cgi?id=64203

Attachment 100163: Patch
https://bugs.webkit.org/attachment.cgi?id=100163&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100163&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewCo
ntroller.js:513
> +		       item.appendChild(document.createTextNode('\u22ee'));

Nit: I would suggest either defining a const VerticalEllipsis = '\u22ee' or
putting an inline comment here, like // Vertical ellipsis.


More information about the webkit-reviews mailing list