[webkit-reviews] review granted: [Bug 63251] [WebKit2] Forward focus events to windowless plugins on the windows port. : [Attachment 100089] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted noel gordon
<noel.gordon at gmail.com>'s request for review:
Bug 63251: [WebKit2] Forward focus events to windowless plugins on the windows
port.
https://bugs.webkit.org/show_bug.cgi?id=63251

Attachment 100089: Patch
https://bugs.webkit.org/attachment.cgi?id=100089&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100089&action=review


> Source/WebKit2/ChangeLog:10
> +2011-07-08  Noel Gordon  <noel.gordon at gmail.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [WebKit2] Forward focus events to windowless plugins on the windows
port.
> +	   https://bugs.webkit.org/show_bug.cgi?id=63251
> +
> +	   * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
> +	   (WebKit::NetscapePlugin::platformSetFocus):
> +

Please mention what test(s) this is covered by, for posterity's sake.

> Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:316
>      CurrentPluginSetter setCurrentPlugin(this);
>  
> -    notImplemented();
> +    if (m_isWindowed)
> +	   return;

Maybe we should put the early return above the CurrentPluginSetter?