[webkit-reviews] review granted: [Bug 64193] TestFailures page incorrectly thinks all tests passed in http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14589 after a reload : [Attachment 100143] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 8 12:06:59 PDT 2011


Daniel Bates <dbates at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 64193: TestFailures page incorrectly thinks all tests passed in
http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14589
after a reload
https://bugs.webkit.org/show_bug.cgi?id=64193

Attachment 100143: Patch
https://bugs.webkit.org/attachment.cgi?id=100143&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100143&action=review


r=me

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Layout
TestResultsLoader.js:33
> +	   const currentCachedDataVersion = 3;

Are there semantics on when we increment this?


More information about the webkit-reviews mailing list