[webkit-reviews] review granted: [Bug 64192] It's hard to tell how many test-webkitpy/test-webkitperl tests failed when looking at build.webkit.org : [Attachment 100141] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 64192: It's hard to tell how many test-webkitpy/test-webkitperl tests
failed when looking at build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=64192

Attachment 100141: Patch
https://bugs.webkit.org/attachment.cgi?id=100141&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100141&action=review


Seems reasonable to me.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:393
> +	   regex = re.compile(r'^Failed \d+/\d+ test programs\.
(?P<count>\d+)/\d+ subtests failed\.')

These regexps could be compile at class evaluation time instead of function
execution time.  Doubt it matters.