[webkit-reviews] review granted: [Bug 63955] Add framework for a new/dummy XMLDocumentParser : [Attachment 100139] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jeffrey Pfau <jeffrey at endrift.com>'s
request for review:
Bug 63955: Add framework for a new/dummy XMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=63955

Attachment 100139: Patch
https://bugs.webkit.org/attachment.cgi?id=100139&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100139&action=review


> Source/WebCore/xml/parser/NewXMLDocumentParser.h:37
> +class NewXMLDocumentParser : public ScriptableDocumentParser, public
CachedResourceClient {

NewXMLDocumentParser probably won't need to be a CachedResourceClient (or at
least we can add that when needed).

> Source/WebCore/xml/parser/NewXMLDocumentParser.h:53
> +    NewXMLDocumentParser(Document*);

This can be private.

> Source/WebCore/xml/parser/NewXMLDocumentParser.h:68
> +    // CachedResourceClient
> +    virtual void notifyFinished(CachedResource*);

This can probably also be removed.