[webkit-reviews] review granted: [Bug 63528] Complete functions in filesystem.py : [Attachment 100067] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 63528: Complete functions in filesystem.py
https://bugs.webkit.org/show_bug.cgi?id=63528

Attachment 100067: Patch
https://bugs.webkit.org/attachment.cgi?id=100067&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100067&action=review


> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:341
> +    def __init__(self, fs, path):
> +	   super(WritableTextFileObject, self).__init__(fs, path)

I think super is worse :)  If you insist on having __init__, let's change this
back to WritableTextFileObject.__init__(self, fs, path).

I don't like the pass through constructors because if you add a param to the
base class, you have to find and fix all the subclasses.  It's easy to miss
some because it's not a compile error.	But calling .__init__ explicitly is OK
too.