[webkit-reviews] review denied: [Bug 13061] Let plugins participate in form submission : [Attachment 100075] Patch V1

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 13061: Let plugins participate in form submission
https://bugs.webkit.org/show_bug.cgi?id=13061

Attachment 100075: Patch V1
https://bugs.webkit.org/attachment.cgi?id=100075&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100075&action=review


> Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:809
> +    if (variable == NPPVformValue) {
> +	   static const char formValue[] = "Plugin form value";
> +	   *((void**)value) = browser->memalloc(sizeof(formValue));
> +	   if (!*((void**)value))
> +	       return NPERR_OUT_OF_MEMORY_ERROR;
> +	   strncpy(*((char**)value), formValue, sizeof(formValue));
> +	   return NPERR_NO_ERROR;
> +    }

We've been trying to put less code in the main.cpp part of the test plug-in,
and instead factor test specific code out into TestNetscapePlugIn/Tests/. It
should be straightforward to add a specific test file just for this.