[webkit-reviews] review granted: [Bug 59114] Move makeSecure from WTF::String to renderText : [Attachment 100121] patch 2

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Chang Shu <cshu at webkit.org>'s
request for review:
Bug 59114: Move makeSecure from WTF::String to renderText
https://bugs.webkit.org/show_bug.cgi?id=59114

Attachment 100121: patch 2
https://bugs.webkit.org/attachment.cgi?id=100121&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100121&action=review


> Source/JavaScriptCore/wtf/text/WTFString.h:226
>      void makeUpper() { if (m_impl) m_impl = m_impl->upper(); }
> -    void makeSecure(UChar aChar) { if (m_impl) m_impl =
m_impl->secure(aChar); }
> +    void fill(UChar aChar)
> +    {
> +	   if (m_impl)
> +	       m_impl = m_impl->fill(aChar);
> +    }

Why does this use a different style than functions above?

I'd have named the variable "character" or "c", not "aChar".