[webkit-reviews] review canceled: [Bug 62808] [Qt] ASSERTION FAILED in ResourceHandle::setDefersLoading causes crash : [Attachment 98732] updated with Yael's comments

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has canceled yi shen
<yi.4.shen at nokia.com>'s request for review:
Bug 62808: [Qt] ASSERTION FAILED in ResourceHandle::setDefersLoading causes
crash
https://bugs.webkit.org/show_bug.cgi?id=62808

Attachment 98732: updated with Yael's comments
https://bugs.webkit.org/attachment.cgi?id=98732&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98732&action=review

Why don't you explain the problem and why this patch is the right solution to
solve it?

> Source/WebCore/ChangeLog:9
> +	   Resume the page loading asynchronously.
> +

You don't explain anything about the patch here.

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:153
> +    : QObject(0)

That is unecessary.
And actually not correct, this should be nullptr.