[webkit-reviews] review requested: [Bug 63982] Web Inspector: [REGRESSION r89753-89754] highlight does not respect scroller location. : [Attachment 100061] [PATCH] First Attempt

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 63982: Web Inspector: [REGRESSION r89753-89754] highlight does not respect
scroller location.
https://bugs.webkit.org/show_bug.cgi?id=63982

Attachment 100061: [PATCH] First Attempt
https://bugs.webkit.org/attachment.cgi?id=100061&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
This fixes all the issues I encountered with highlight rects being wrong when
I scrolled in the main frame. I tested scrolling in the main frame, subframes,
and transformed versions of nested frames etc.

I'm a bit frustrated now that the FloatQuad version of
FrameView::convertFromRenderer
is so different from the IntRect version. I wonder why these two differences
(root view
and fixed content) aren't handled in the IntRect version and if maybe my
understanding
of what this function really does is wrong and it should be renamed. I'd like
to look deeper
at this when I have some more time, but this appears to fix the regression.