[webkit-reviews] review denied: [Bug 64137] test-webkitpy fails on chromium win : [Attachment 100054] clarify comments per eseidel's review

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 64137: test-webkitpy fails on chromium win
https://bugs.webkit.org/show_bug.cgi?id=64137

Attachment 100054: clarify comments per eseidel's review
https://bugs.webkit.org/attachment.cgi?id=100054&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100054&action=review


>> Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:40
>> +	FILES_HAVE_FORWARD_SLASHES = sys.platform != 'win32'
> 
> This is more clear, but I'm still confused why os.path.sep isn't our friend
here?

Maybe it isn't worth the effort to make this platform-agnostic.  I don't know. 
That's your judgment call to make.  But it's not immediately obvious to me why
it's not platform-agnostic automatically if we're using os.path.sep where we're
supposed to.  I don't see any '/' in these tests themselves.  Should we be
making this check inside assertOverridesWorked instead of in each test?