[webkit-reviews] review denied: [Bug 64137] test-webkitpy fails on chromium win : [Attachment 100053] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 64137: test-webkitpy fails on chromium win
https://bugs.webkit.org/show_bug.cgi?id=64137

Attachment 100053: Patch
https://bugs.webkit.org/attachment.cgi?id=100053&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100053&action=review


> Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:37
> +    # FIXME: We don't test some of the combinations on win32 because paths
are returned using the Win32 "\\" conventions
> +    # and the tests will fail. It's unclear if there's a good solution to
this.

I'm confused by this statement.

> Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:40
> +	   if sys.platform != 'win32':

A constant on the class or in the file would read better than checking in each
place.