[webkit-reviews] review granted: [Bug 64077] DFG JIT does not implement get_by_id prototype caching : [Attachment 99963] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 7 16:17:14 PDT 2011


Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 64077: DFG JIT does not implement get_by_id prototype caching
https://bugs.webkit.org/show_bug.cgi?id=64077

Attachment 99963: the patch
https://bugs.webkit.org/attachment.cgi?id=99963&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
I think there might be an alternative given the way we're currently code
generating the self accesses.  We may be able to plant a couple of extra
instructions inline in the JIT code to load to prototype & check its structure,
immediately prior to the load.	But this is just a possible idea to explore -
patch as is looks fine.


More information about the webkit-reviews mailing list