[webkit-reviews] review granted: [Bug 63490] [Qt] Add more tests to cover the behavior of loadFinished() signal : [Attachment 98809] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Caio Marcelo de Oliveira
Filho <cmarcelo at webkit.org>'s request for review:
Bug 63490: [Qt] Add more tests to cover the behavior of loadFinished() signal
https://bugs.webkit.org/show_bug.cgi?id=63490

Attachment 98809: Patch
https://bugs.webkit.org/attachment.cgi?id=98809&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98809&action=review

The patch looks correct but I am not sure ErrorPage isn't leaked.

> Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2579
> +    ErrorPage* page = new ErrorPage;

Why is this page allocated on the stack? Isn't it leaked?
QWebView::setPage() does not take ownership.