[webkit-reviews] review denied: [Bug 63133] [CSSRegions]Parse content: from-flow : [Attachment 99958] Patch 3

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 63133: [CSSRegions]Parse content: from-flow
https://bugs.webkit.org/show_bug.cgi?id=63133

Attachment 99958: Patch 3
https://bugs.webkit.org/attachment.cgi?id=99958&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99958&action=review

Looks good but I forgot you need the -webkit- prefix for any new values you add
to already-standardized properties.

> Source/WebCore/css/CSSParser.cpp:2661
> +	       } else if (equalIgnoringCase(val->function->name, "from-flow("))
{

Seems like this needs to be "-webkit-from-flow", since we're putting it into an
existing property, and this value is still non-standard.

> Source/WebCore/css/CSSPrimitiveValue.cpp:695
> +	       text = "from-flow(" + quoteCSSStringIfNeeded(m_value.string) +
")";

Same here... -webkit-from-flow and not just from-flow.