[webkit-reviews] review granted: [Bug 64118] Move all code related to cachedSelection to HTMLTextFormControlElement : [Attachment 100020] Removed lots of code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 7 13:56:39 PDT 2011


Alexey Proskuryakov <ap at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 64118: Move all code related to cachedSelection to
HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64118

Attachment 100020: Removed lots of code
https://bugs.webkit.org/attachment.cgi?id=100020&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=100020&action=review


> Source/WebCore/html/HTMLFormControlElement.cpp:715
> +    if (!renderer() || !isTextFormControl())

When is HTMLTextFormControlElement not a text form control?

> Source/WebCore/html/HTMLFormControlElement.h:238
> +    int m_cachedSelectionStart;
> +    int m_cachedSelectionEnd;

What prevents these from being private?


More information about the webkit-reviews mailing list