[webkit-reviews] review granted: [Bug 63914] SVGAnimateTransform does not support calcMode=discrete : [Attachment 100017] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 63914: SVGAnimateTransform does not support calcMode=discrete
https://bugs.webkit.org/show_bug.cgi?id=63914

Attachment 100017: Patch
https://bugs.webkit.org/attachment.cgi?id=100017&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=100017&action=review


Ok with some comments that you need to fix before landing.

> Source/WebCore/ChangeLog:8
> +	   Apply transform at 0% of animation if current percentage is smaller
than 0.5 and at 100% if not.

Could be made more clear, you could start with Implement calcMode=discrete
by... This sounds like a programmer speaking :) Try to incorporate the "This
specifies that the animation function will jump from one value to the next
without any interpolation." and why 0.5 was chosen.

> Source/WebCore/ChangeLog:10
> +	   Added a manual test. DRT crashes on an automated test with the SVG
animation API. Opened a new bug report: 64104.

Could add the tracking bug for the animation framework problem.

> Source/WebCore/manual-tests/svg-animateTransform-calcMode-discrete.svg:2
> +<text x="10" y="20">Testing calcMode="discrete" for
<animateTransform>. The rect should move without an interpoalted
translation after 2s.</text>

interpoalted? Maybe reword a bit, maybe you can just use "jump" like in the
spec definition.