[webkit-reviews] review denied: [Bug 64086] [Qt] NRWT should pick up the right httpd config file : [Attachment 99977] proposed fix

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Andras Becsi <abecsi at webkit.org>'s
request for review:
Bug 64086: [Qt] NRWT should pick up the right httpd config file
https://bugs.webkit.org/show_bug.cgi?id=64086

Attachment 99977: proposed fix
https://bugs.webkit.org/attachment.cgi?id=99977&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.  There is a similar "is_redhat_based()" function in the Gtk port.

Please add a test for this in qt_unittest.py.  Should be very easy to do with
MockFileSystem({'/etc/debian_version', ''})

Something like this:

def test_is_debian_based(self)
    port = self.make_port() # This is available in PortTestCase which
QtPortTest isn't yet, I don't think, but could be made to
    self.assertEqual(port.is_debian_based(), False)
    port._filesystem = MockFileSystem({'/etc/debian_version', ''})
    self.assertEqual(port.is_debian_based(), True)

One could also test that overriding _is_debian_based() with lamba: False or
lambda: True affected port._path_to_appache_config_file().basename() if you
wanted.  In any case, we just need some sort of testing.