[webkit-reviews] review granted: [Bug 64093] [Qt][WK2] Views should know about WebProcess crash/relaunch. : [Attachment 99988] Proposed patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 64093: [Qt][WK2] Views should know about WebProcess crash/relaunch.
https://bugs.webkit.org/show_bug.cgi?id=64093

Attachment 99988: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=99988&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99988&action=review

> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:229
> +    isCrashed = false;

Don't you need to update here?

> Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:548
>      setDrawingAreaSize(m_viewInterface->drawingAreaSize());
> -
> -    m_isConnectedToEngine = true;
> +    m_viewInterface->didRelaunchProcess();

I would invert the order of those calls. :)