[webkit-reviews] review granted: [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's : [Attachment 99985] Add a --print-log option to commit-log-editor

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 26755: webkit-patch's commit messages are less readable than
commit-log-editor's
https://bugs.webkit.org/show_bug.cgi?id=26755

Attachment 99985: Add a --print-log option to commit-log-editor
https://bugs.webkit.org/attachment.cgi?id=99985&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99985&action=review

r=me, although consider fixing the exit issues.

> Tools/Scripts/commit-log-editor:50
>  sub usage

Consider renaming to printUsageAndExit() so it's more descriptive.

> Tools/Scripts/commit-log-editor:73
> +    exit !$getOptionsResult;

This exit doesn't do anything because usage() already exits.

> Tools/Scripts/commit-log-editor:81
> +	   exit 1;

Ditto.

> Tools/Scripts/commit-log-editor:84
> +    exit;

"exit 0;" ?