[webkit-reviews] review granted: [Bug 64075] Move remaining enums out of SVG*Element classes : [Attachment 99960] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 7 04:39:56 PDT 2011


Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 64075: Move remaining enums out of SVG*Element classes
https://bugs.webkit.org/show_bug.cgi?id=64075

Attachment 99960: Patch
https://bugs.webkit.org/attachment.cgi?id=99960&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99960&action=review

r=me. Not sure if you should remove the comment about forward declaration or
add it to all elements. Up to you:

> Source/WebCore/svg/SVGTextContentElement.h:75
> +    // Forward declare these enums in the w3c naming scheme, for IDL
generation

I wounder why you did not add this comment on the other enums like for
SVGMarker or SVGGradient?!?


More information about the webkit-reviews mailing list