[webkit-reviews] review denied: [Bug 63955] Add framework for a new/dummy XMLDocumentParser : [Attachment 99895] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 7 01:24:01 PDT 2011
Adam Barth <abarth at webkit.org> has denied Jeffrey Pfau <jeffrey at endrift.com>'s
request for review:
Bug 63955: Add framework for a new/dummy XMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=63955
Attachment 99895: Patch
https://bugs.webkit.org/attachment.cgi?id=99895&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
I think you're falling into a bad trap with this patch. You're accepting
XMLDocumentParser.h has given, but that header has a bunch of junk in it that
we don't want to have contaminate the new parser. Can we start with a cleaner
slate? You should be able to just create a new subclass of
ScriptableDocumentParser and use an ifdef at the construction site.
More information about the webkit-reviews
mailing list