[webkit-reviews] review granted: [Bug 64070] Remove style_references.py : [Attachment 99955] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 7 01:03:26 PDT 2011
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 64070: Remove style_references.py
https://bugs.webkit.org/show_bug.cgi?id=64070
Attachment 99955: Patch
https://bugs.webkit.org/attachment.cgi?id=99955&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99955&action=review
> Tools/Scripts/check-webkit-style:64
> +def detect_checkout():
> + """Return a WebKitCheckout instance, or None if it cannot be found."""
> + cwd = os.path.abspath(os.curdir)
> + return detect_scm_system(cwd)
Why not just inline this incorectly named method? Its only called one place,
or?
More information about the webkit-reviews
mailing list