[webkit-reviews] review denied: [Bug 63622] Web Inspector: Adding CSS properties results in messy style rules : [Attachment 99818] [PATCH] Chromium build fix

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 63622: Web Inspector: Adding CSS properties results in messy style rules
https://bugs.webkit.org/show_bug.cgi?id=63622

Attachment 99818: [PATCH] Chromium build fix
https://bugs.webkit.org/attachment.cgi?id=99818&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99818&action=review

> Source/WebCore/inspector/InspectorStyleSheet.cpp:352
> +void
InspectorStyle::ensureFormatPropertyPrefix(Vector<InspectorStyleProperty>&
allProperties)

I think detection should be based upon CSSRuleSourceData instead. I.e. you get
CSS markup and detect the indentation.

> Source/WebCore/inspector/InspectorStyleSheet.cpp:697
> +    if (!newTextLength && fullPrefixLength) {

This is way too much math in a single method. Can it be split?