[webkit-reviews] review granted: [Bug 63999] Web Inspector: Add support for clearing cache and cookies from network panel. : [Attachment 99848] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 63999: Web Inspector: Add support for clearing cache and cookies from
network panel.
https://bugs.webkit.org/show_bug.cgi?id=63999

Attachment 99848: Patch
https://bugs.webkit.org/attachment.cgi?id=99848&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99848&action=review

r+ with nits.

>
LayoutTests/http/tests/inspector/network/network-clear-cookies.html-disabled:14

> +    internals.setInspectorResourcesDataSizeLimits(document, 10 * 1000 *
1000, 1000 * 1000);

This should be a part of the network-test.js

> Source/WebCore/inspector/InspectorClient.h:55
> +    virtual void clearBrowserCache() { };

nuke ;

> Source/WebCore/inspector/InspectorResourceAgent.cpp:478
> +void InspectorResourceAgent::clearBrowserCache(ErrorString* errorString)

Mac build failed with unused errorString

> Source/WebCore/inspector/InspectorResourceAgent.cpp:483
> +void InspectorResourceAgent::clearBrowserCookies(ErrorString* errorString)

ditto

> Source/WebKit/chromium/public/WebDevToolsAgentClient.h:62
> +    virtual void clearBrowserCache() { };

nuke ;