[webkit-reviews] review granted: [Bug 64056] Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests : [Attachment 99943] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 64056: Fix WebKit2 expected results search paths for Mac and Qt under
new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=64056

Attachment 99943: Patch
https://bugs.webkit.org/attachment.cgi?id=99943&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99943&action=review

> Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py:77
> -	   port = mac.MacPort()
> +	   port = MacPort(filesystem=MockFileSystem(), user=MockUser(),
executive=MockExecutive())

This all seems very copy/pasted.

> Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py:137
> +	   # FIXME: Is this really right?  Should mac-leopard fallback to
mac-snowleopard?

Yes.  The fallback logic somewhat convoluted and revolves around the expected
migration path for baselines when adding new version of a platform.

> Tools/Scripts/webkitpy/layout_tests/port/qt.py:52
> +	   if platform.startswith('linux'):
> +	       return "linux"
> +	   elif platform in ('win32', 'cygwin'):
> +	       return "win"
> +	   elif platform == 'darwin':
> +	       return "mac"
> +	   return None

This feels more general than its current location.