[webkit-reviews] review granted: [Bug 62752] [GTK] Transition to Mozilla named cursors have incorrect hotspot and rendering : [Attachment 97357] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 6 21:03:07 PDT 2011


Daniel Bates <dbates at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 62752: [GTK] Transition to Mozilla named cursors have incorrect hotspot and
rendering
https://bugs.webkit.org/show_bug.cgi?id=62752

Attachment 97357: Patch
https://bugs.webkit.org/attachment.cgi?id=97357&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97357&action=review

> Source/WebCore/ChangeLog:11
> +	   * manual-tests/cursor.html: The grab cursor div covers this change.

Nit: On my first read of this commit message I thought you that you were adding
this test since you use the same '*:' style as prepare-ChangeLog. I suggest
writing a complete sentence instead of using the same notation. Maybe something
like: "This change is covered by the grab cursor div in
manual-tests/cursor.html."


More information about the webkit-reviews mailing list