[webkit-reviews] review granted: [Bug 64048] Move a bunch of classes out of layout_tests.layout_package and into layout_tests.controllers : [Attachment 99913] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 6 19:14:53 PDT 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 64048: Move a bunch of classes out of layout_tests.layout_package and into
layout_tests.controllers
https://bugs.webkit.org/show_bug.cgi?id=64048

Attachment 99913: Patch
https://bugs.webkit.org/attachment.cgi?id=99913&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99913&action=review

OK.

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:155
> -	       options.time_out_ms = str(2 *
manager.Manager.DEFAULT_TEST_TIMEOUT_MS)
> +	       options.time_out_ms = str(2 * Manager.DEFAULT_TEST_TIMEOUT_MS)

I don't think this has any business on Manager.  Eventually we'll move it.


More information about the webkit-reviews mailing list