[webkit-reviews] review denied: [Bug 63987] Bridge RenderBoxModelObject::calculateBackgroundImageGeometry parameters into a class : [Attachment 99821] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 6 19:12:40 PDT 2011
MORITA Hajime <morrita at google.com> has denied Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 63987: Bridge RenderBoxModelObject::calculateBackgroundImageGeometry
parameters into a class
https://bugs.webkit.org/show_bug.cgi?id=63987
Attachment 99821: Patch
https://bugs.webkit.org/attachment.cgi?id=99821&action=review
------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99821&action=review
> Source/WebCore/rendering/RenderBoxModelObject.h:44
> +public:
Could you make fields private and add accessors for them?
Few new classes have public member variables.
More information about the webkit-reviews
mailing list