[webkit-reviews] review denied: [Bug 64044] Don't call into Image::loadPlatformResource() for Chromium Autofill popup items without icons : [Attachment 99901] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 64044: Don't call into Image::loadPlatformResource() for Chromium Autofill
popup items without icons
https://bugs.webkit.org/show_bug.cgi?id=64044

Attachment 99901: Patch
https://bugs.webkit.org/attachment.cgi?id=99901&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99901&action=review

R- for lack of tests.

> Source/WebCore/ChangeLog:8
> +	   No new tests because the changes are all in platform-specific
Chromium Autofill code.

That's not a reason not to have tests!

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1043
> +	 image = Image::loadPlatformResource(itemIcon.utf8().data());

Bad indent

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1192
> -    RefPtr<Image> image(Image::loadPlatformResource(icon.utf8().data()));
> +    RefPtr<Image> image;
> +    if (!icon.isEmpty())
> +	 image = Image::loadPlatformResource(icon.utf8().data());

I don't really understand this pattern.  Why doesn't loadPlatformResource just
return a null ptr if icon is empty?

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1382
> +	     iconImage = Image::loadPlatformResource(icon.utf8().data());

Bad indent.