[webkit-reviews] review denied: [Bug 63897] [CSSRegions] Parse content-order property : [Attachment 99636] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 63897: [CSSRegions] Parse content-order property
https://bugs.webkit.org/show_bug.cgi?id=63897

Attachment 99636: Patch
https://bugs.webkit.org/attachment.cgi?id=99636&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99636&action=review

Minor nits.

> LayoutTests/ChangeLog:13
> +	   ():
> +	   (testComputedStyle):
> +	   (testNotInherited):

Not sure why the changelog did this, but you can just remove these lines.

> Source/WebCore/css/CSSStyleSelector.cpp:4882
> +	   if (primitiveValue)

Confused why HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE can't be used here.

> Source/WebCore/rendering/style/RenderStyle.h:1099
> +    void setRegionIndex(int i) { SET_VAR(rareNonInheritedData,
m_regionIndex, i); }

Change "i" to "index" please. We don't like single-letter variable names for
parameters.