[webkit-reviews] review denied: [Bug 63133] [CSSRegions]Parse content: from-flow : [Attachment 99470] Patch 2

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 63133: [CSSRegions]Parse content: from-flow
https://bugs.webkit.org/show_bug.cgi?id=63133

Attachment 99470: Patch 2
https://bugs.webkit.org/attachment.cgi?id=99470&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99470&action=review

Couple of nits.

> Source/WebCore/css/CSSParser.h:160
> +	   PassRefPtr<CSSValue> parseFromFlowContent(CSSParserValueList* args);


You can omit the word "args" here. Typically if the type of the parameter makes
it obvious what you've got, we just omit the name in headers.

> Source/WebCore/css/CSSStyleSelector.cpp:4165
> +

Useless whitespace change. Get rid of this. Thanks.

> Source/WebCore/rendering/style/RenderStyle.h:1099
> +    void setRegionThread(const AtomicString& n) {
SET_VAR(rareNonInheritedData, m_regionThread, n); }

Can omit "n" here.