[webkit-reviews] review granted: [Bug 64027] garden-o-matic should use a favicon to indicate current state. : [Attachment 99873] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 64027: garden-o-matic should use a favicon to indicate current state.
https://bugs.webkit.org/show_bug.cgi?id=64027

Attachment 99873: Patch
https://bugs.webkit.org/attachment.cgi?id=99873&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99873&action=review

> Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:48
> +<link rel=icon id=favicon type=image/png href=favicon-green.png>

pls use " around attribute values.

> Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:18
> +    document.getElementById('favicon').href = 'favicon-' + (hasFailures ?
'red' : 'green') + '.png';

I was thinking we'd use jQuery to interact with the DOM:

var faviconURL = 'favicon-' + (hasFailures ? 'red' : 'green') + '.png';
$('#favicon').attr('href', faviconURL);

I'm not sure it really matters, but just to be consistent.