[webkit-reviews] review granted: [Bug 61877] TestFailures page doesn't show testers that use new-run-webkit-tests : [Attachment 99869] Teach TestFailures how to load, parse, and interpret NRWT test results

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 61877: TestFailures page doesn't show testers that use new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=61877

Attachment 99869: Teach TestFailures how to load, parse, and interpret NRWT
test results
https://bugs.webkit.org/attachment.cgi?id=99869&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99869&action=review

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTRe
sultsParser.js:65
> +		   if (expectedArray.contains('FAIL') && ['IMAGE', 'TEXT',
'IMAGE+TEXT'].contains(actualValue))

FAIL includes all of these:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/servers/data/g
ardeningserver/results.js#L17

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTRe
sultsParser.js:88
> +	       return 'unknown failure type ' + nrwtResult;

AUDIO will fall into this category, for example.