[webkit-reviews] review granted: [Bug 63640] Switch RenderLayer::hitTest* to to new layout types : [Attachment 99362] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 6 12:58:37 PDT 2011
Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 63640: Switch RenderLayer::hitTest* to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63640
Attachment 99362: Patch
https://bugs.webkit.org/attachment.cgi?id=99362&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99362&action=review
>> Source/WebCore/rendering/LayoutTypes.h:52
>> +}
>
> These methods scare me. What is this going to do when you move LayoutPoint
to float? Is it going to still round?
I'm OK with this, assuming you all plan to audit all these callsites at some
point.
More information about the webkit-reviews
mailing list