[webkit-reviews] review denied: [Bug 63951] ASSERT_NOT_REACHED running test 262 : [Attachment 99851] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 6 11:44:11 PDT 2011
Gavin Barraclough <barraclough at apple.com> has denied review:
Bug 63951: ASSERT_NOT_REACHED running test 262
https://bugs.webkit.org/show_bug.cgi?id=63951
Attachment 99851: patch
https://bugs.webkit.org/attachment.cgi?id=99851&action=review
------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Actually, I gave a bad review here. We really should have a regression test
covering this, if possible. Could you look into this? We should be able to
add something to a regression test to check this syntax error is thrown
correctly. Could you try to produce a simple test that triggers the bug, and
add to a layout test? (LayoutTests/fast/js/reserved-words might be a candidate
if this is reserved-words specific, or there may be a existing syntax-errors
related test, or you can add a new test case). Hope that sounds reasonable.
More information about the webkit-reviews
mailing list