[webkit-reviews] review denied: [Bug 63857] [DRT] implement createPopupMenu for Chromium DRT port : [Attachment 99545] patch v1

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Johnny(Jianning) Ding
<jnd at chromium.org>'s request for review:
Bug 63857: [DRT] implement createPopupMenu for Chromium DRT port
https://bugs.webkit.org/show_bug.cgi?id=63857

Attachment 99545: patch v1
https://bugs.webkit.org/attachment.cgi?id=99545&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99545&action=review

Just some small style nits.

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:249
> +	   if (widget)

Nit: Do we really need this check?  Shouldn't WebPopupMenu::create always
succeed?

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:254
> +    default:
> +	   ASSERT_NOT_REACHED();

I would remove the default case.  That way if someone adds another
WebPopupType, there will be a compiler error and the person can update this
code.

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:261
> +    // In Chromium, we do not this method.

Nit: This comment isn't that useful.  Can you either explain why we don't need
this method or just remove the comment?