[webkit-reviews] review granted: [Bug 63995] [Qt] [WK2] Add touch mocking to Qt's Minibrowser : [Attachment 99839] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 63995: [Qt] [WK2] Add touch mocking to Qt's Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=63995

Attachment 99839: Patch
https://bugs.webkit.org/attachment.cgi?id=99839&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99839&action=review

r=me with some kennethisms

> Tools/ChangeLog:3
> +	   [Qt] [WK2] Add touch mocking to Qt's Minibrowser

MiniBrowser!!!111twotwotwo

> Tools/ChangeLog:8
> +	   The mouse event are intercepted through QCoreApplication::notify(),

event -> events

> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:83
> +    /* We try to be smart, if we received real touch event, we are probably
on a device
> +	  with touch screen, and we should not have touch mocking */

// comments, please!