[webkit-reviews] review granted: [Bug 63977] [ShadowContentElement] Redundant RenderText objects are created on the content boundaries : [Attachment 99797] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 63977: [ShadowContentElement] Redundant RenderText objects are created on
the content boundaries
https://bugs.webkit.org/show_bug.cgi?id=63977

Attachment 99797: Patch
https://bugs.webkit.org/attachment.cgi?id=99797&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99797&action=review

pls address the nits.

>> LayoutTests/fast/dom/shadow/content-element-renderers.html:13
>> +	document.getElementById("console").innerText += (message + "\n");
> 
> WebKit zeitgeist seems to prefer textContent over innerText?

yup -- and don't use +=, as abbreviated as it sounds, it's highly inefficient.

How's this:

var log = document.getElementById("console");
log.info = function(message)
{
    this.appendChild(document.createElement("div")).textContent = message;
}
// ...
log.info('foo');