[webkit-reviews] review denied: [Bug 52262] More keybindings for input[type=range] : [Attachment 99809] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 52262: More keybindings for input[type=range]
https://bugs.webkit.org/show_bug.cgi?id=52262

Attachment 99809: Patch
https://bugs.webkit.org/attachment.cgi?id=99809&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99809&action=review

r- because the key operations are not compatible with Windows.

> Source/WebCore/html/RangeInputType.cpp:202
> +    if (key == "Up" || key == "Right")
> +	   newValue = current + step;
> +    else if (key == "Down" || key == "Left")
> +	   newValue = current - step;
> +    else if (key == "PageDown")
> +	   newValue = current + bigStep;
> +    else if (key == "PageUp")
> +	   newValue = current - bigStep;
> +    else if (key == "Home")
> +	   newValue = minimum();
> +    else if (key == "End")
> +	   newValue = maximum();
> +    else
> +	   return; // Did not match any key binding.

A horizontal slider in Control panel -> Keyboard in Windows 7 behaves:
 Up: Increase the value
 Down: Decrease the value
 PageUp: Increase the value by a large amount
 PageDown: Decrease the value by a large amount
 Home: Jump to the minimum value
 End: Jump to the maximum value

A vertical slider in Volume mixer in Windows 7 behaves:
 Right: decrease the value
 Left: Increase the value
 PageUp: Increase the value by a large amount
 PageDown: Decrease the value by a large amount
 Home: Jump to the maximum value
 End: Jump to the minimum value

You can detect slider orientation by renderer()->style()->appearance().