[webkit-reviews] review requested: [Bug 63975] [EFL] Add Fullscreen API feature : [Attachment 99829] Modified Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 6 07:32:45 PDT 2011
Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked for review:
Bug 63975: [EFL] Add Fullscreen API feature
https://bugs.webkit.org/show_bug.cgi?id=63975
Attachment 99829: Modified Patch
https://bugs.webkit.org/attachment.cgi?id=99829&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
I fix this patch according to your comments.
>> if one sets ENABLE_FULLSCREEN_API to ON, the build will fail or things will
not work later, right? If so, I prefer to hold this commit until the missing
implementation enters the tree.
If RenderFullScreen.cpp is missed when this feature is enabled on current
version, build error happens. So, though ENABLE_FULLSCREEN_API is turned on,
there is no build break on this patch . I'd like to implement remained missing
things step by step after landing this patch.
More information about the webkit-reviews
mailing list