[webkit-reviews] review requested: [Bug 54476] HTMLInputElement has two similarly named methods: "checked" and "isChecked" : [Attachment 99805] Patch v1

[bugzilla-daemon at webkit.org]

SravanKumar <sravan.ken at gmail.com> has asked  for review:
Bug 54476: HTMLInputElement has two similarly named methods: "checked" and
"isChecked"
https://bugs.webkit.org/show_bug.cgi?id=54476

Attachment 99805: Patch v1
https://bugs.webkit.org/attachment.cgi?id=99805&action=review

------- Additional Comments from SravanKumar <sravan.ken at gmail.com>
HTMLInputElement::isChecked() is called only for Radio button & Checkboxes.
When a radiobutton or checkbox is set, checked() returns TRUE &
m_inputType->isCheckable() also returns TRUE. Therefore to find out whether a
radio button or checkbox is set, checking checked() is sufficient, no need to
check for m_inputType->isCheckable().

Therefore, we have replaced all the instances of isChecked() with checked().

Also, we have tested the radio/checkbox related test cases in
LayoutTest/fast/forms, so no need to add additional test cases.